Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redis.configmap to replace values in redis.conf instead of appending to end #31365

Open
prpercival opened this issue Jan 14, 2025 · 1 comment

Comments

@prpercival
Copy link

Name and Version

bitnami/redis-cluster 11.2.1

What is the problem this feature will solve?

Allowing the redis.configmap parameter (or a new parameter) to replace a value in the redis configuration file instead of appending to the end of the file will make the bitnami/redis-cluster chart more flexible and allow using the default config map and only changing specific values instead of having to define an entire config map using redis.defaultConfigOverride.

What is the feature you are proposing to solve the problem?

Create a redis.configMapOverride parameter that will override existing entries in the default config map.

What alternatives have you considered?

  • Defining our own config map with redis.defaultConfigOverride, but part of the benefit of using this helm chart is having some defaults set already.
  • Modifying redis.args to set the relevant config map variables as part of the command line args, but then we drift away from any future changes made to the helm chart related to default args.
  • Modifying the template to add explicit parameters for each config map variable we want to customize, but this can become very cumbersome and verbose to account for all options.
@github-actions github-actions bot added the triage Triage is needed label Jan 14, 2025
@prpercival
Copy link
Author

prpercival commented Jan 14, 2025

For some specific examples, when attempting to set redis RDB policy, both of the solutions below append the value 43200 1 to the existing config value instead of overwriting it. So as far as I can tell, there isn't a good way to overwrite the policy.

redis:
  configmap: |-
  save 43200 1
redis:
  extraEnvVars:
    - name: REDIS_RDB_POLICY
      value: "43200#1"

@github-actions github-actions bot removed the triage Triage is needed label Jan 15, 2025
@github-actions github-actions bot assigned alvneiayu and unassigned carrodher Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants