Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deployer.resourcesPreset property not respected for stream apps #31301

Open
onobc opened this issue Jan 10, 2025 · 2 comments
Open

The deployer.resourcesPreset property not respected for stream apps #31301

onobc opened this issue Jan 10, 2025 · 2 comments
Assignees
Labels
spring-cloud-dataflow tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@onobc
Copy link
Contributor

onobc commented Jan 10, 2025

Name and Version

bitnami/spring-cloud-dataflow latest

What architecture are you using?

arm64

What steps will reproduce the bug?

In any environment, install the Spring Cloud Dataflow Helm chart and set the deployer.resourcesPreset property in your values.yml.

Launch a stream application from Spring Cloud Dataflow. The resource values will not be applied to the pod when the stream app is launched.

What is the expected behavior?

When the stream app is launched, the value from deployer.resourcesPreset should be applied to the pod.

What do you see instead?

The value from deployer.resourcesPreset is not applied to the pod where the stream app is launched.

Additional information

The deployer.resourcesPreset configuration property should apply to both stream apps and task apps.

It is supported for task apps but not for stream apps.

This was discovered when investigating spring-cloud/spring-cloud-dataflow#6099.

@onobc onobc added the tech-issues The user has a technical issue about an application label Jan 10, 2025
@github-actions github-actions bot added the triage Triage is needed label Jan 10, 2025
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

@onobc
Copy link
Contributor Author

onobc commented Jan 12, 2025

Thanks @carrodher , I wanted to just push a PR rather than this issue but ran out of time. I will try to contribute the fix this week though - it is straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring-cloud-dataflow tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
Development

No branches or pull requests

2 participants