Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on timeline for dropping Pydantic 2 #1199

Open
cthoyt opened this issue Oct 10, 2024 · 2 comments
Open

Decide on timeline for dropping Pydantic 2 #1199

cthoyt opened this issue Oct 10, 2024 · 2 comments

Comments

@cthoyt
Copy link
Member

cthoyt commented Oct 10, 2024

Pydantic v2 has been out for more than a year, and it's time to decide on a timeline for dropping cross-compatibility with Pydantic v1.

We have to do this because the amounts of deprecations and warnings are a big risk for the code staying up to date in the future, and it's not economical to keep so much legacy code around.

The carrot is that the Pydantic v2 API enables a lot of interesting things for annotating models, and APIs with FastAPI (see the https://github.com/cthoyt/semantic-pydantic experiment).

I posted on the OBO slack a few months back and basically nobody had any complaints, except for https://github.com/gyorilab/mira which was on Pydantic v1 only. It now appears to be compatible with Pydantic v2 as of gyorilab/mira#360.

I think that switching over at the beginning of 2025 is a reasonable timeline. Any alternate suggestions?

@bgyori
Copy link
Contributor

bgyori commented Oct 16, 2024

Yes, we migrated MIRA to Pydantic v2 (it turned out to be a lot of work but it's done now) so that is not an issue anymore. More generally, there are many Python packages that use bioregistry as a dependency and it's hard to assess the downstream effect systematically. Two remarks related to this:

Generally, my view is that in a package that is likely one of many dependencies of downstream packages, it's better to err on the side of broad compatibility to avoid (as in the case Pydantic v1->v2) potentially time consuming migration. But I don't have a very strong feeling about it.

@bgyori
Copy link
Contributor

bgyori commented Oct 17, 2024

Fwiw I submitted an inquiry to GitHub support and they did something on the back-end that fixed the dependents page: https://github.com/biopragmatics/bioregistry/network/dependents. This is a really interesting view of who uses the Bioregistry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants