💅 Using unsafe fix triggers an infinite cycle!

[ElrohirGT]

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-ghostty"
  JS_RUNTIME_VERSION:           "v22.12.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.15.3"

Biome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

Rule name

useNamingConvention and noUnusedVariables

Playground link

https://github.com/ElrohirGT/biome-repro-1737140798250

Expected result

I've been using biome and loving it on almost all my JS/TS projects.

When I tried to use it on a really big repo with a lot of rules generated the biome migration command it generated a lot of errors, some were fixable others unsafe to fix but I wanted to try it anyways. After running biome lint --fix --unsafe . it stayed running for more than a second, something is wrong, I waited 10s and it still didn't finish.

After reviewing my configuration I can say it isn't related to trying to lint node_modules and after running biome with the debug log level I can see that 2-3 filenames were appearing repedeately! As far as I can tell is because of the interactions between those two rules but it may well be another thing.

I expected biome to finish executing and to unsafely fix the rules.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[dyc3]

That config is quite big. Would you be able to reduce it to create a minimal reproduction? Ideally, it should be pretty clear from the repro which rule is causing the loop.

[ElrohirGT]

I'll give it a try! I'll post a coment here once I get it working with a minimal config

[ElrohirGT]

Done! Now the biome.json contains only 2 rules!