Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the required resdk package version #345

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

JureZmrzlikar
Copy link
Contributor

The resdk package API had breaking changes that affect the "Genialis Expressions" widget. To keep the widget usable one needs to have latest version of resdk.

@markotoplak
Copy link
Member

I saw that -oldest tests were crashing because of some pandas issue, so I required pandas==1.3 for the -oldest tests. Now those pass, but all the others fail.

All tests on master, -oldest or not, use resdk>=20.0.0, so that should not be the issue. Any ideas, @JakaKokosar?

@JureZmrzlikar
Copy link
Contributor Author

I saw that -oldest tests were crashing because of some pandas issue, so I required pandas==1.3 for the -oldest tests. Now those pass, but all the others fail.

All tests on master, -oldest or not, use resdk>=20.0.0, so that should not be the issue. Any ideas, @JakaKokosar?

I do not have deep insight into these tests, but the failing test is the one that seems to connect with https://dictyexpress.research.bcm.edu/ and is failing due to some connectivity issue. Maybe:
a) the Dicty webapp was not active at the time of the test
b) the REST API of the Dicty app page changed

This is just observation from first time contributor, so don't take my observation too seriously :-)

@JakaKokosar
Copy link
Member

I am trying to identify the issue. I can't reproduce failing tests locally...

@JakaKokosar
Copy link
Member

Failing test is unrelated to this PR. I will handle that with new PR.

@JakaKokosar JakaKokosar merged commit 082406f into biolab:master Nov 9, 2023
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants