Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #637 #735

Merged
merged 14 commits into from
Oct 24, 2024
Merged

Closes #637 #735

merged 14 commits into from
Oct 24, 2024

Conversation

davidkartchner
Copy link
Contributor

Add the plant-phenotype dataset. Closes #637

New location for dataset (that corrects errors of nested/missing entities): https://github.com/davidkartchner/PPRcorpus

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

davidkartchner and others added 11 commits May 26, 2022 23:54
* edit

* unchange

* stats

* added init for ptm

* added proc meta script

* add single

* add vis code

* added vis changes

* remove proc file

* add vis code

* add paper script

* edit scripts

* edit scripts

* add readme

* remove wip code

* add ngram back in

* black and isort vis code

* move

* added pdfs

* added pdfs that are not local and not broken

* added agg pdf
@davidkartchner
Copy link
Contributor Author

@galtay @hakunanatasha Are the main blockers to merging this updating this to be consistent with the other hf-hub dataloaders? And is CONTRIBUTING.md updated so with instructions of what needs to be done to put it in the correct format? If so, I can update and resubmit.

@mariosaenger mariosaenger self-assigned this Oct 23, 2024
@mariosaenger
Copy link
Collaborator

@phlobo I refactored the implementation to the new hub style integration and fixed some minor issues. Please have a look at it.

Copy link
Collaborator

@phlobo phlobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super interesting dataset, lgtm!

@phlobo phlobo merged commit 28d0c95 into bigscience-workshop:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for PPR corpus
7 participants