-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught (in promise) TypeError: Cannot read property 'physicalItems' of undefined: cart.js:71 #148
Comments
Hi @Mikhail-MM, This is currently fixed in #137. And this will be released with next version 6.7.0 (#147) of stencil-utils |
@jairo-bc Thanks for the quick response, Is this related to this PR in Cornerstone (bigcommerce/cornerstone#1920)? I've seen some issues on Chrome local development where adding to cart + going to the cart page will result in an empty cart, trying to make sense of why this is happening, I'm worried that there is a de-sync between the CartID returned by Stencil Utils & The CartID injectd by BigCommerce Context |
@Mikhail-MM That PR is mostly about cleaning up the cornerstone. The fix is already applied on the cornerstone, it's only requires the newer version of stencil utils that will come up early next week |
@jairo-bc Do you know which version number of cornerstone/ which Pull Request this was patched in on cornerstone? We have some older client themes that are running into this and we may need to do some work on our end to avoid issues. |
@Mikhail-MM cornerstone will need a new release, after the stencil-utils release is done, before we're able to use this fix. |
@rowleyaj I see, thank you. I'll keep an eye out on the changelog so that we can merge the updates in selectively. I'm still trying to find the best way to keep our custom themes in sync with latest cornerstone updates. Once we begin to work on a theme for a client using a any version of cornerstone our development tends to branch off completely. We're still trying to find a way to be able to automatically merge critical changes into Cornerstone using GitHub without seeing merge conflicts |
@Mikhail-MM stencil-utils 6.7.0 was released to npm. |
Hello,
I've been seeing this error on multiple Cornerstone themes.
This happens on page-load, I assume this is happening when you land on a BC page and have an empty cart, potentially related to the theme checking for the quantity in cart to update the count-pill.
This is the error that shows up in console:
Origin of the error is
/stencil-utils/src/api/cart.js
Any ideas on how to resolve, is this a problem with a cornerstone version, or stencil utils version, or both?
The text was updated successfully, but these errors were encountered: