Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headerless Panel has additional marginTop #1447

Open
bobbyshaw opened this issue Jun 12, 2024 · 2 comments
Open

Headerless Panel has additional marginTop #1447

bobbyshaw opened this issue Jun 12, 2024 · 2 comments

Comments

@bobbyshaw
Copy link
Contributor

Describe the bug

Panels without a header but just content now have a marginTop.

Screenshot 2024-06-12 at 09 18 09

Due to this change

As per @leeBigCommerce's comment in the PR, I'm not sure about the full list of use cases you're prepared to support in the Panel component or whether your recommendation would be for us to rebuild with a Box (probably what we'll do in this instance but thought I'd share in case it affects others).

@chanceaclark
Copy link
Contributor

Hey @bobbyshaw, curious if you can solve this by throwing everything into header, description, and action props?

Screenshot 2024-06-12 at 10 08 40

I believe that would be more inline with our design guidelines, otherwise I think I would take your approach of rebuilding it with a Box 🤔

@bobbyshaw
Copy link
Contributor Author

Hi @chanceaclark. Ah yes, I could definitely take that approach. I think at the time I wanted the action to be more vertically central as the whole panel is clickable. This particular component is an edge case and taking a step away from BigDesign guidelines (sorry, not sorry 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants