Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing arrow line when there is more than one Arrow Shape with Label #26

Open
germanocaumo opened this issue Mar 10, 2023 · 1 comment
Open

Missing arrow line when there is more than one Arrow Shape with Label #26

germanocaumo opened this issue Mar 10, 2023 · 1 comment
Milestone
4.0.3

Comments

@germanocaumo
Copy link
Contributor

Only the first arrow shape of the page is draw correctly with an Label, the other ones are "invisible" and just the label is shown
@kepstin
Copy link
Contributor

kepstin commented Mar 10, 2023

This sounds like there might be a cairo state save() and restore() mismatch somewhere in the arrow or label code.

@kepstin kepstin mentioned this issue Mar 13, 2023
Merged
@kepstin kepstin added this to the 4.0.0 milestone Mar 17, 2023
kepstin added a commit to kepstin/bbb-presentation-video that referenced this issue Mar 23, 2023
@kepstin
Use a context manager for balancing cairo save/restore
92cc004 
When attempting to debug bigbluebutton#26, my initial thought was that it was a
problem with unbalanced context save/restore. So I wrote a context
manager to ensure that the save/restore is always balanced properly.
Unfortunately this doesn't actually seem to be the cause of the problem,
but it still is a useful code cleanup.

There's also a context manager for handling pushing/popping groups to
ensure those stay balanced too.
@kepstin kepstin modified the milestones: 4.0.0, 4.0.1 Mar 24, 2023
@kepstin kepstin modified the milestones: 4.0.1, 4.0.2, 4.0.3 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.3
Development

No branches or pull requests
2 participants
@kepstin @germanocaumo