Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimize example docker image size #25

Open
yarikoptic opened this issue Feb 1, 2019 · 5 comments
Open

minimize example docker image size #25

yarikoptic opened this issue Feb 1, 2019 · 5 comments

Comments

@yarikoptic
Copy link
Contributor

ATM it is whooping 1.13GB so takes time to download it. And then together with #24 it just becomes somewhat disappointing to wait to just get no sensible output.

@Remi-Gau
Copy link
Contributor

Remi-Gau commented May 9, 2024

OK things have gotten worse now

the image is based on neurodocker based build of FSL... and we now have a 15 Go image...

it'd be nice if neurodocker did not create image that crush my will to live

@yarikoptic
Copy link
Contributor Author

I think the demo bids-app should be a bash script which does something basic and hopefully somewhat useful. Then base image could be literally a few MBs if that. Here is a starting point I thought to pursue at some point but never got to it: https://github.com/yarikoptic/bids-basher/

@Remi-Gau
Copy link
Contributor

I like the idea BUT... this repo is also a template got help people get started, so it should at least contains the bids validator.

But I agree that it probably should not have FSL and conda and all the extra fluff the current one has, if only because it makes for a bad template.

Could probably look into how to make the base validator thinner: https://github.com/bids-apps/base_validator/blob/master/Dockerfile

@yarikoptic
Copy link
Contributor Author

Is bids-validator a requirement for a bids-apps? Although might be a good idea IMHO isn't a requirement really - and in reality I see a lot of uses where people just explicitly disable validate for their fmriprep etc runs

@Remi-Gau
Copy link
Contributor

https://bids-apps.neuroimaging.io/dev_faq/#is-it-mandatory-to-first-check-the-dataset-validity-using-the-bids-validator

image

However... If we want the example repo be an example of good practices, I think it should contain the validator.

Sure people can skip validation, but as an app developer I would then be able to say the behaviors / outputs are much less guaranteed if you skip validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants