IT-6019 Fix hover state on IconButton on mobile #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
rogatty
reviewed
Oct 17, 2024
|
/build |
rogatty
reviewed
Oct 28, 2024
| @@ -351,9 +354,13 @@ export default defineComponent({ | |||
| }, | |||
| }, | |||
| }, | |||
| setup() { | |||
There was a problem hiding this comment.
Can I use both APIs in the same component?
Yes. You can use Composition API via the setup() option in an Options API component.
However, we only recommend doing so if you have an existing Options API codebase that needs to integrate with new features / external libraries written with Composition API.
https://vuejs.org/guide/extras/composition-api-faq.html#can-i-use-both-apis-in-the-same-component
Fine, we can unify later when we're sure on <script setup> vs defineComponent()
rogatty
reviewed
Oct 28, 2024
rogatty
reviewed
Oct 28, 2024
|
/review |
|
Your storybook is available on: https://wnl-design-system-preview.s3.amazonaws.com/IT-6019/index.html |
rogatty
reviewed
Oct 28, 2024
rogatty
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.