From 71abcaec795e815b1be16681027f4848e49fc501 Mon Sep 17 00:00:00 2001 From: Przemek Ferkaluk Date: Tue, 7 May 2024 13:37:35 +0200 Subject: [PATCH 01/13] add none to POP_OVER_TRIGGER_ACTIONS --- lib/js/components/PopOver/PopOver.consts.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/js/components/PopOver/PopOver.consts.ts b/lib/js/components/PopOver/PopOver.consts.ts index d5d69a319..51af3d398 100644 --- a/lib/js/components/PopOver/PopOver.consts.ts +++ b/lib/js/components/PopOver/PopOver.consts.ts @@ -6,6 +6,7 @@ export const POP_OVER_COLORS = { export const POP_OVER_TRIGGER_ACTIONS = { CLICK: 'click', HOVER: 'hover', + NONE: 'none', } as const; export const POP_OVER_PLACEMENTS = { From c2c5dc63afd841df4db80a91ba77920a969525b0 Mon Sep 17 00:00:00 2001 From: Przemek Ferkaluk Date: Tue, 7 May 2024 15:35:50 +0200 Subject: [PATCH 02/13] remove none from trigger actions, add shouldDisplay prop --- lib/js/components/PopOver/PopOver.consts.ts | 1 - lib/js/components/PopOver/PopOver.vue | 54 ++++++++++++--------- 2 files changed, 30 insertions(+), 25 deletions(-) diff --git a/lib/js/components/PopOver/PopOver.consts.ts b/lib/js/components/PopOver/PopOver.consts.ts index 51af3d398..d5d69a319 100644 --- a/lib/js/components/PopOver/PopOver.consts.ts +++ b/lib/js/components/PopOver/PopOver.consts.ts @@ -6,7 +6,6 @@ export const POP_OVER_COLORS = { export const POP_OVER_TRIGGER_ACTIONS = { CLICK: 'click', HOVER: 'hover', - NONE: 'none', } as const; export const POP_OVER_PLACEMENTS = { diff --git a/lib/js/components/PopOver/PopOver.vue b/lib/js/components/PopOver/PopOver.vue index fea000c97..fd04714bf 100644 --- a/lib/js/components/PopOver/PopOver.vue +++ b/lib/js/components/PopOver/PopOver.vue @@ -12,32 +12,34 @@ :visible-arrow="isPointerVisible" :root-class="rootClass" > -
- -
-
{{ titleText }}
-
{{ subtitleText }}
-
- +