-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the extension / repo #25
Comments
You might find this discussion on zero-to-jupyterhub useful, it includes a Dockerfile: |
Indeed thanks for the pointer @manics - looking quickly at that PR it seems that all that is needed for what they're describing is exactly this type of minimal Dockerfile that just adds code to the base jupyter image. Doesn't require any changes to JH at all and if you give the users the choice of default starting URL they can just launch straight into VSCode. Anyway, I'll read the rest of that thread and add comments there :) |
Here's a Dockerfile that works:
I'd be happy to make a PR that adds this is a documentation of sorts but I'm not sure where it should go. |
See what @betatim thinks regarding how he wants to manage this repo, but one option could be to create your own repo, setup an automated build on Docker Hub (or some other system) and link to it from the README? |
This repo is constructed to work with
repo2docker
which is great and fulfills the original purpose of spinning up VSCode on Binder. Would it be useful to provide a more general Dockerfile based onjupyter/base-notebook
for those who don't userepo2docker
and/or binder but do use the Jupyter stack in their docker images?The text was updated successfully, but these errors were encountered: