Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overrides methods from KubeSpawner #4831

Open
ryanlovett opened this issue Aug 7, 2023 · 1 comment
Open

Use overrides methods from KubeSpawner #4831

ryanlovett opened this issue Aug 7, 2023 · 1 comment
Assignees

Comments

@ryanlovett
Copy link
Collaborator

Summary

We apply overrides in our CustomKubeSpawner to change things like memory allocations and mount paths. The upstream KubeSpawner also has methods for doing such things. We should call upstream methods and stop using our own code. Hopefully we can get to a point where we don't need a customer spawner.

I believe the appropriate exposed method is now load_user_options. We may need to override this in our subclass since we do not use forms to set configuration.

User Stories

  • Where appropriate, we should either upstream our code or use upstream's code. This lessens development and maintenance time.

Acceptance criteria

  • When we can remove our apply_override method and have the same functionality.
@shaneknapp
Copy link
Contributor

PR to move the spawn delay and timer/patience message upstream: jupyterhub/kubespawner#825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants