Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask:: Fail notification to use NotificationFailed Event. #34

Open
setkyar opened this issue Mar 27, 2019 · 5 comments
Open

Ask:: Fail notification to use NotificationFailed Event. #34

setkyar opened this issue Mar 27, 2019 · 5 comments

Comments

@setkyar
Copy link

setkyar commented Mar 27, 2019

Hi @benwilkins

Did you have any plan to add NotificationFailed when notification got failed? If so, I would like to make a PR.

Currently, when notification got failed. It was going to failed_jobs. Instead of that, by using NotificationFailed event, we can customize whatever we want. Like adding a status column to notifications table and customizing base on success and failure?

@setkyar
Copy link
Author

setkyar commented Mar 27, 2019

@benwilkins You can see example usage on other packages.

@poklin
Copy link

poklin commented Apr 25, 2019

Do you guys have any guide for receiving the response? I keep getting a blank/null response but the notification is sent successfully

@setkyar
Copy link
Author

setkyar commented Apr 26, 2019

@poklin I don't have any issue with receiving the notification response. Also, take a check notification events on official docs.

@poklin
Copy link

poklin commented Apr 26, 2019

@setkyar Yup, I did check and created Event and Listener. But I do not what is the "key word" to get the response back from FCMChannel. If I do dd() inspection on the FCMChannel, I did receive the response, just I do not know how to retrieve it from the front. >.<

@ankurk91
Copy link
Contributor

@benwilkins

I can send a PR for the NotificationFailed.
Laravel does not emit this event by default, package developer need to handle and dispatch it.
See example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants