Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckECRImageExists function return wrong result when too many tags exist in repository. #77

Open
wellshs opened this issue Dec 22, 2022 · 0 comments

Comments

@wellshs
Copy link

wellshs commented Dec 22, 2022

I experienced that yatai-deployment try to build images which already exist in ecr repository.

aws-sdk-go's list images doesn't ensure list all the images from repository. It returns 100 as default.
I'm not sure how to support this case in yatai-deployment.
But, I think only checking only 100 results is too small for current usecase.(Share one repository for all bentos)
Currently, I'm trying to handle this issue with ECR repository lifecycle policy.

references

  1. input := &ecr.ListImagesInput{
  2. https://docs.aws.amazon.com/sdk-for-go/api/service/ecr/#ListImagesInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant