Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: default a runner's extraPodSpec to the BentoDeployment's value when it's not explicitly set #136

Open
mqk opened this issue Feb 9, 2024 · 0 comments

Comments

@mqk
Copy link

mqk commented Feb 9, 2024

Bentos can contain many runners. Currently if one wants all runners to have the same extraPodSpec (for example to set a toleration) you have to specify it separately for each runner. It would be convenient if the runners could instead "inherit" a default value of extraPodSpec from the parent BentoDeployment. My concrete use case for this is that I would like all bento-related pods (both service and all of its runners) to be running on a non-default k8s node pool, which I can achieve by adding a toleration. However, in the current set-up it needs to be done "manually" for the service and each of the runners.

I'm not 100% confident that this is right, but it looks to me like here is where the runner's extraPodSpec is set. If we only did that assignment if runner.ExtraPodSpec was non-nil, then the previously defined value (from opt.bentoDeployment.Spec.ExtraPodSpec, l.2501) would instead be used. I think that would do what I'm asking for.

Any thoughts about this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant