You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bentos can contain many runners. Currently if one wants all runners to have the same extraPodSpec (for example to set a toleration) you have to specify it separately for each runner. It would be convenient if the runners could instead "inherit" a default value of extraPodSpec from the parent BentoDeployment. My concrete use case for this is that I would like all bento-related pods (both service and all of its runners) to be running on a non-default k8s node pool, which I can achieve by adding a toleration. However, in the current set-up it needs to be done "manually" for the service and each of the runners.
I'm not 100% confident that this is right, but it looks to me like here is where the runner's extraPodSpec is set. If we only did that assignment if runner.ExtraPodSpec was non-nil, then the previously defined value (from opt.bentoDeployment.Spec.ExtraPodSpec, l.2501) would instead be used. I think that would do what I'm asking for.
Any thoughts about this solution?
The text was updated successfully, but these errors were encountered:
Bentos can contain many runners. Currently if one wants all runners to have the same
extraPodSpec
(for example to set a toleration) you have to specify it separately for each runner. It would be convenient if the runners could instead "inherit" a default value ofextraPodSpec
from the parent BentoDeployment. My concrete use case for this is that I would like all bento-related pods (both service and all of its runners) to be running on a non-default k8s node pool, which I can achieve by adding a toleration. However, in the current set-up it needs to be done "manually" for the service and each of the runners.I'm not 100% confident that this is right, but it looks to me like here is where the runner's
extraPodSpec
is set. If we only did that assignment ifrunner.ExtraPodSpec
was non-nil, then the previously defined value (fromopt.bentoDeployment.Spec.ExtraPodSpec
, l.2501) would instead be used. I think that would do what I'm asking for.Any thoughts about this solution?
The text was updated successfully, but these errors were encountered: