Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all legacy client and components towards v1 #478

Closed
mantzas opened this issue Mar 5, 2022 · 7 comments · Fixed by #602
Closed

Deprecate all legacy client and components towards v1 #478

mantzas opened this issue Mar 5, 2022 · 7 comments · Fixed by #602
Assignees
Labels
enhancement New feature or request

Comments

@mantzas
Copy link

mantzas commented Mar 5, 2022

Is your feature request related to a problem? Please describe

For our v1 release we should only have only the latest clients and components.

Describe the solution

  • Delete all legacy client and components
  • Move all remaining to the right place
@mantzas mantzas added the enhancement New feature or request label Mar 5, 2022
@mantzas mantzas added this to the v1.0.0 Release milestone Mar 5, 2022
@wishperera
Copy link

Can i take this task once #581 is closed?

@mantzas
Copy link
Author

mantzas commented Oct 23, 2022

Great. The only problem I see is since this is a breaking change and we have introduced multiple ones if we should follow the pattern of breaking one thing per release.
@wishperera @xenosdio @pkritiotis WDYT?

@wishperera
Copy link

I agree it is a safer approach.

@mantzas
Copy link
Author

mantzas commented Oct 24, 2022

Would it make sense to list them all and add them as a bullet list and sub-tasks as we have done it here?

@xenosdio
Copy link
Collaborator

Great. The only problem I see is since this is a breaking change and we have introduced multiple ones if we should follow the pattern of breaking one thing per release.
@wishperera @xenosdio @pkritiotis WDYT?

It is a safer approach, but what would be optimal? Each version introducing a breaking change, hence upgrading Patron would require updating the code, or all changes occurring in one single version? I would lean toward the latter.

@wishperera
Copy link

@xenosdio makes a good point , from a consumer's view point, multiple breaking changes in consecutive releases is a hassle.

@mantzas
Copy link
Author

mantzas commented Oct 25, 2022

So we have either a big-bang breaking change that affects everybody or smaller changes that might affect some people (based on what they use). Example: not all use AWS so the breaking change blast radius is smaller.

With breaking changes per release we can provide simpler upgrade instructions. Big bang might be a mess...
I am not sure about which is the best, I tend to prefer the later in smaller steps.

@mantzas mantzas self-assigned this Jan 3, 2023
mantzas added a commit that referenced this issue Jan 13, 2023
<!--
Thanks for taking precious time for making a PR.

Before creating a pull request, please make sure:
- Your PR solves one problem for which an issue exist and a solution has
been discussed
- You have read the guide for contributing
- See
https://github.com/beatlabs/patron/blob/master/README.md#how-to-contribute
- You signed all your commits (otherwise we won't be able to merge the
PR)
  - See https://github.com/beatlabs/patron/blob/master/SIGNYOURWORK.md
- You added unit tests for the new functionality
- You mention in the PR description which issue it is addressing, e.g.
"Resolves #123"
-->

## Which problem is this PR solving?

Closes #478.

## Short description of the changes

- Removed v1 amqp package
- Remove v1 kafka package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants