-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate all legacy client and components towards v1 #478
Comments
Can i take this task once #581 is closed? |
Great. The only problem I see is since this is a breaking change and we have introduced multiple ones if we should follow the pattern of breaking one thing per release. |
I agree it is a safer approach. |
Would it make sense to list them all and add them as a bullet list and sub-tasks as we have done it here? |
It is a safer approach, but what would be optimal? Each version introducing a breaking change, hence upgrading Patron would require updating the code, or all changes occurring in one single version? I would lean toward the latter. |
@xenosdio makes a good point , from a consumer's view point, multiple breaking changes in consecutive releases is a hassle. |
So we have either a big-bang breaking change that affects everybody or smaller changes that might affect some people (based on what they use). Example: not all use AWS so the breaking change blast radius is smaller. With breaking changes per release we can provide simpler upgrade instructions. Big bang might be a mess... |
<!-- Thanks for taking precious time for making a PR. Before creating a pull request, please make sure: - Your PR solves one problem for which an issue exist and a solution has been discussed - You have read the guide for contributing - See https://github.com/beatlabs/patron/blob/master/README.md#how-to-contribute - You signed all your commits (otherwise we won't be able to merge the PR) - See https://github.com/beatlabs/patron/blob/master/SIGNYOURWORK.md - You added unit tests for the new functionality - You mention in the PR description which issue it is addressing, e.g. "Resolves #123" --> ## Which problem is this PR solving? Closes #478. ## Short description of the changes - Removed v1 amqp package - Remove v1 kafka package
Is your feature request related to a problem? Please describe
For our v1 release we should only have only the latest clients and components.
Describe the solution
The text was updated successfully, but these errors were encountered: