Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-1394 Remove i18n dependencies from frontend #682

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Oct 19, 2023

  • Needed to cleanup the use of i18n in the frontend
  • Remove all references and the npm dependencies
  • Double checked using grep grep -r --exclude-dir=node_modules i18

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

https://jira.th.gov.bc.ca/browse/ORV2-1394

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Went through the Vehicle Inventory forms to check proper form field labels
  • Went through the Profile screens to check proper form field labels

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erikataot erikataot temporarily deployed to dev October 19, 2023 21:55 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 19, 2023 21:55 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 19, 2023 21:55 — with GitHub Actions Inactive
@erikataot erikataot merged commit 40f393a into main Oct 19, 2023
16 checks passed
@erikataot erikataot deleted the ORV2-remove-i18n-from-frontend branch October 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants