Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-1433 adding a sticky navigation button bar for IDIR users #672

Merged
merged 13 commits into from
Oct 6, 2023
Merged

ORV2-1433 adding a sticky navigation button bar for IDIR users #672

merged 13 commits into from
Oct 6, 2023

Conversation

erikataot
Copy link
Contributor

@erikataot erikataot commented Oct 5, 2023 •
edited by github-actions bot
Loading

Description

  • Created a navigation button bar that is "sticky" to the left side of each page of the app
  • The button bar should only be visible for users authenticated with an IDIR account

Screenshot 2023-10-05 130920

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@erikataot erikataot temporarily deployed to dev October 5, 2023 19:09 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:09 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:09 — with GitHub Actions Inactive
zgong-gov
zgong-gov reviewed Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@zgong-gov zgong-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments, thanks.

@erikataot erikataot temporarily deployed to dev October 5, 2023 19:51 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:51 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:59 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:59 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 19:59 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 5, 2023 20:30 — with GitHub Actions Inactive
@erikataot erikataot marked this pull request as ready for review October 5, 2023 22:21
@erikataot erikataot temporarily deployed to dev October 6, 2023 00:29 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 6, 2023 00:29 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 6, 2023 00:29 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erikataot erikataot temporarily deployed to dev October 6, 2023 16:25 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 6, 2023 16:25 — with GitHub Actions Inactive
@erikataot erikataot temporarily deployed to dev October 6, 2023 16:25 — with GitHub Actions Inactive
@erikataot erikataot merged commit e405b55 into main Oct 6, 2023
16 checks passed
@erikataot erikataot deleted the ORV2-1433-sticky-sidebar branch October 6, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgong-gov zgong-gov zgong-gov left review comments

@krishnan-aot krishnan-aot krishnan-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikataot @krishnan-aot @zgong-gov