Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORV2-1346 #670

Merged
merged 57 commits into from
Oct 5, 2023
Merged

ORV2-1346 #670

merged 57 commits into from
Oct 5, 2023

Conversation

zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Oct 3, 2023

Description

  • Includes all permit void and revoke functionalities on the frontend and backend
  • Refactoring of previously used components and styles for application/permit creation, as well as addition and consolidation of permit and payment related types and helper methods
  • Database audit columns added, as well as schema changes
  • Additional backend endpoints and processes relating to permit issuance, payment and transaction, document generation, as well as void/revoke
  • Bug fixes for permit issue/payment success page on UI

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run all previous unit tests on the frontend and make sure they all pass
  • Go through the entire application/permit creation process, payment process, and verify that the permit is indeed issued and its permit and receipt PDFs generated successfully
  • Login as IDIR user with SYSADMIN role, go to the permit search page and verify that an active permit can be voided via the void button, and go through the process of voiding/revoking and verify that the process works properly.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

zgong-gov and others added 30 commits August 23, 2023 16:43
…rmit data, refactor void permit pages, add breadcrumb for links
…on history table and styles, refactor FE fee summary code, complete FE missing void logic
@praju-aot praju-aot temporarily deployed to dev October 5, 2023 15:28 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 5, 2023 15:28 — with GitHub Actions Inactive
@praju-aot praju-aot temporarily deployed to dev October 5, 2023 15:28 — with GitHub Actions Inactive
@zgong-gov zgong-gov temporarily deployed to dev October 5, 2023 17:29 — with GitHub Actions Inactive
@zgong-gov zgong-gov temporarily deployed to dev October 5, 2023 17:29 — with GitHub Actions Inactive
@zgong-gov zgong-gov temporarily deployed to dev October 5, 2023 17:29 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:00 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:00 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:00 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

Copy link
Collaborator

@praju-aot praju-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved +

@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:50 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:50 — with GitHub Actions Inactive
@gchauhan-aot gchauhan-aot temporarily deployed to dev October 5, 2023 18:50 — with GitHub Actions Inactive
@zgong-gov zgong-gov merged commit 1c55ac2 into main Oct 5, 2023
16 checks passed
@zgong-gov zgong-gov deleted the ORV2-1346 branch October 5, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants