Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard fulltext search creation for environments where fulltext not enabled #652

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Sep 20, 2023

Description

Quick change to allow database version 8 to run without throwing errors on a database instance without fulltext search installed (such as current ORBC_PRD).

Fixes # N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue

How Has This Been Tested?

  • Executed DDL script for v8 as part of Docker database load process (with fulltext search enabled), confirmed no errors
  • Reverted fulltext search for Docker database, confirmed the error is trapped successfully and database upgrades proceed to version 9
  • Ran script manually against a v7 MOTI database with fulltext search disabled, confirmed error trapped successfully

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (N/A)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend - Vehicles available
Backend - DOPS available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:33 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:33 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:33 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:33 — with GitHub Actions Inactive
gchauhan-aot
gchauhan-aot previously approved these changes Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:52 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:52 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:52 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot temporarily deployed to dev September 20, 2023 19:52 — with GitHub Actions Inactive
@john-fletcher-aot john-fletcher-aot merged commit 02a9335 into main Sep 20, 2023
@john-fletcher-aot john-fletcher-aot deleted the ORV2-1458-2 branch September 20, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants