Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-to-left address salvage #335

Open
BK01 opened this issue Nov 18, 2022 · 2 comments
Open

Right-to-left address salvage #335

BK01 opened this issue Nov 18, 2022 · 2 comments
Labels
Milestone

Comments

@BK01
Copy link
Contributor

BK01 commented Nov 18, 2022

Build a right-to-left address salvage mode to acquire a locality matchPrecision level. Utilize salvage mode if the resulting fullAddress is ‘BC’ with a score of 1.

Test case fullAddress (current state) fullAddress (future state)
GENERAL DELIVERY 1471 WHI, CEDAR, BC BC CEDAR, BC
PO BOX 19675 RPO CTRE/POINT/MALL, VANCOUVER, BC BC VANCOUVER, BC
PO BOX 19675 RPO CTRE/POINT/MALL BC BC
@BK01 BK01 added this to the Geocoder 4.3 milestone Nov 18, 2022
@cmhodgson
Copy link
Collaborator

The implemented solution does not make use of a fallback "salvage mode" but instead adds support for a different parsing that allows for unlimited garbage in front of the locality name but penalizes it hard, which results in the same net effect.

@BK01
Copy link
Contributor Author

BK01 commented Dec 13, 2023

Validated in geocodertst (Geocoder 4.3) that the examples above no longer return a score of 1 with a matchPrecision of Province. The Geocoder's updated parsing handles more garbage in front of the locality name and tries to interpret what remains. To review the above examples again with the team next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants