Merge pull request #238 from bcgov/ticdi-109

fix provision group deletion
bcgov · Oct 1, 2024 · fc6730f · fc6730f
2 parents d59466c + 5160aae
commit fc6730f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/backend/src/document_type/document_type.module.ts b/backend/src/document_type/document_type.module.ts
@@ -4,9 +4,14 @@ import { TypeOrmModule } from '@nestjs/typeorm';
 import { DocumentTypeController } from './document_type.controller';
 import { DocumentType } from './entities/document_type.entity';
 import { ProvisionGroup } from './entities/provision_group.entity';
+import { DocumentTypeProvision } from 'src/provision/entities/document_type_provision';
 
 @Module({
-  imports: [TypeOrmModule.forFeature([DocumentType]), TypeOrmModule.forFeature([ProvisionGroup])],
+  imports: [
+    TypeOrmModule.forFeature([DocumentType]),
+    TypeOrmModule.forFeature([ProvisionGroup]),
+    TypeOrmModule.forFeature([DocumentTypeProvision]),
+  ],
   providers: [DocumentTypeService],
   controllers: [DocumentTypeController],
   exports: [DocumentTypeService],

diff --git a/backend/src/document_type/document_type.service.ts b/backend/src/document_type/document_type.service.ts
@@ -3,14 +3,17 @@ import { InjectRepository } from '@nestjs/typeorm';
 import { In, Repository } from 'typeorm';
 import { DocumentType } from './entities/document_type.entity';
 import { ProvisionGroup } from './entities/provision_group.entity';
+import { DocumentTypeProvision } from 'src/provision/entities/document_type_provision';
 
 @Injectable()
 export class DocumentTypeService {
   constructor(
     @InjectRepository(DocumentType)
     private documentTypeRepository: Repository<DocumentType>,
     @InjectRepository(ProvisionGroup)
-    private provisionGroupRepository: Repository<ProvisionGroup>
+    private provisionGroupRepository: Repository<ProvisionGroup>,
+    @InjectRepository(DocumentTypeProvision)
+    private documentTypeProvisionRepository: Repository<DocumentTypeProvision>
   ) {}
 
   async findById(id: number): Promise<DocumentType | undefined> {
@@ -120,6 +123,11 @@ export class DocumentTypeService {
   }
 
   async removeProvisionGroup(provision_group_id: number) {
+    await this.documentTypeProvisionRepository.update(
+      { provision_group: { id: provision_group_id } },
+      { provision_group: null }
+    );
+
     const result = await this.provisionGroupRepository.delete(provision_group_id);
 
     if (result.affected === 0) {