Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment to prod not deploying latest version #13

Open
franTarkenton opened this issue May 3, 2023 · 1 comment
Open

Deployment to prod not deploying latest version #13

franTarkenton opened this issue May 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@franTarkenton
Copy link
Member

Current pr-close.yaml action was using latest to deploy to prod. When the helm chart runs because the image tag hasn't changed, no deployment is taking place.

As a quick fix going to use the event-number associated with the PR as the image tag. The PR image tag will get added to the GHCR image, and then the deployment to prod on pr-close will deploy an image using the pr image tag number.
@franTarkenton franTarkenton added the bug Something isn't working label May 3, 2023
@franTarkenton
Copy link
Member Author

tested this by pushing the GHA changes, confirm that the new image with the PR- is what has been deployed

@franTarkenton franTarkenton moved this to Done in RFC Backlog Dec 5, 2023
@franTarkenton franTarkenton moved this from Done to Review / QA in RFC Backlog Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
RFC Backlog
Status: Review / QA
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franTarkenton