From 9b7009a448b91aab8ec3cef900c800396b7a9ec9 Mon Sep 17 00:00:00 2001
From: Paulo Gomes da Cruz Junior <paulushc@gmail.com>
Date: Wed, 29 Nov 2023 10:58:31 -0800
Subject: [PATCH] fix: updating cove coverage report (#197)

* fix: updating cove coverage report

* chore: updating unit tests

* fix: fixing coverage report

* fix: removing report from main and changed token
---
 .github/workflows/merge-main.yml | 18 ++++--------------
 .github/workflows/unit-tests.yml |  2 +-
 .vscode/settings.json            |  6 ++++++
 3 files changed, 11 insertions(+), 15 deletions(-)
 create mode 100644 .vscode/settings.json

diff --git a/.github/workflows/merge-main.yml b/.github/workflows/merge-main.yml
index 4ec4a155..cc06fd88 100644
--- a/.github/workflows/merge-main.yml
+++ b/.github/workflows/merge-main.yml
@@ -40,14 +40,6 @@ jobs:
             -Dsonar.tests=test
           sonar_token: ${{ secrets.SONAR_TOKEN_BACKEND }}
 
-      - name: Report code coverage
-        uses: romeovs/lcov-reporter-action@v0.3.1
-        with:
-          title: Backend coverage report
-          delete-old-comments: true
-          github-token: ${{ secrets.GHCR_TOKEN }}
-          lcov-file: ./backend/coverage/lcov.info
-  
   codeql:
     name: Semantic Code Analysis
     runs-on: ubuntu-22.04
@@ -94,8 +86,7 @@ jobs:
           oc_token: ${{ secrets.OC_TOKEN }}
           overwrite: false
           penetration_test: false
-          parameters:
-            -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
+          parameters: -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
 
   deploy-test-backend:
     name: Deploy Backend on Test Env
@@ -115,7 +106,7 @@ jobs:
           oc_server: ${{ secrets.OC_SERVER }}
           oc_token: ${{ secrets.OC_TOKEN }}
           overwrite: true
-          penetration_test: true          
+          penetration_test: true
           parameters:
             -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
             -p PROMOTE=${{ github.repository }}/backend:${{ env.ZONE }}
@@ -147,8 +138,7 @@ jobs:
           oc_token: ${{ secrets.OC_TOKEN }}
           overwrite: false
           penetration_test: false
-          parameters:
-            -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
+          parameters: -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
 
   deploy-prod-backend:
     name: Deploy Backend on Prod Env
@@ -169,7 +159,7 @@ jobs:
           oc_server: ${{ secrets.OC_SERVER }}
           oc_token: ${{ secrets.OC_TOKEN }}
           overwrite: true
-          penetration_test: true          
+          penetration_test: true
           parameters:
             -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
             -p PROMOTE=${{ github.repository }}/backend:${{ env.PREV }}
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index dfeec43d..d17ad9c4 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -46,7 +46,7 @@ jobs:
         with:
           title: Backend coverage report
           delete-old-comments: true
-          github-token: ${{ secrets.GHCR_TOKEN }}
+          github-token: ${{ github.token }}
           lcov-file: ./backend/coverage/lcov.info
 
   trivy:
diff --git a/.vscode/settings.json b/.vscode/settings.json
new file mode 100644
index 00000000..71ff3846
--- /dev/null
+++ b/.vscode/settings.json
@@ -0,0 +1,6 @@
+{
+    "sonarlint.connectedMode.project": {
+        "connectionId": "bcgov-sonarcloud",
+        "projectKey": "bcgov_nr-old-growth"
+    }
+}
\ No newline at end of file