From 98c9a18921adbc0af8ab70d12f70ea6798027c7b Mon Sep 17 00:00:00 2001
From: Ian Liu <81595625+ianliuwk1019@users.noreply.github.com>
Date: Mon, 8 Jan 2024 11:33:19 -0800
Subject: [PATCH] fix: #488 Only enable timber sales manager when holder is
 timber sales manager. (#551)

* Only enable timber sales manager when holder is timber sales manager.

* Dummy commit (no change) to deploy.

* Minor fixing.

* Remove await, ok to just issue requests.
---
 admin/src/app/foms/fom-add-edit/fom-add-edit.component.html | 5 +----
 admin/src/app/foms/summary/summary.component.html           | 2 +-
 api/README.md                                               | 2 +-
 public/src/index.html                                       | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/admin/src/app/foms/fom-add-edit/fom-add-edit.component.html b/admin/src/app/foms/fom-add-edit/fom-add-edit.component.html
index f5f2b744f..c182775b9 100644
--- a/admin/src/app/foms/fom-add-edit/fom-add-edit.component.html
+++ b/admin/src/app/foms/fom-add-edit/fom-add-edit.component.html
@@ -241,7 +241,7 @@ <h1 class="text-muted">{{isCreate ? 'Add New' : 'Edit'}} FOM {{isCreate ? '' : '
             </div>
           </div>
         </div>
-        <div class="row">
+        <div class="row" *ngIf="isHolderBctsManger()">
           <div class="form-group col">
             <label [ngClass]="{'required': isHolderBctsManger()}">
                 Timber Sales Manager Name
@@ -271,9 +271,6 @@ <h1 class="text-muted">{{isCreate ? 'Add New' : 'Edit'}} FOM {{isCreate ? '' : '
                 {{getErrorMessage('bctsMgrName', 'maxLength')}}
             </div>
           </div>
-
-
-
         </div>
         <div class="row">
           <div class="form-group col-md">
diff --git a/admin/src/app/foms/summary/summary.component.html b/admin/src/app/foms/summary/summary.component.html
index c26d688f6..84113232f 100644
--- a/admin/src/app/foms/summary/summary.component.html
+++ b/admin/src/app/foms/summary/summary.component.html
@@ -54,7 +54,7 @@ <h4>Details</h4>
                   {{project?.forestClient?.name}}
                 </span>
               </li>
-              <li *ngIf="project.bctsMgrName && project.bctsMgrName.length > 0">
+              <li *ngIf="project?.bctsMgrName && project.bctsMgrName.length > 0">
                 <span class="name">Timber Sales Manager Name:</span>
                 <span
                   class="value">
diff --git a/api/README.md b/api/README.md
index 6b22dd75b..9e3484327 100644
--- a/api/README.md
+++ b/api/README.md
@@ -78,5 +78,5 @@ These are the steps to generate the client library used by the frontend componen
     distributed under the License is distributed on an "AS IS" BASIS,
     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and
-    limitations under the License. 
+    limitations under the License.
     
\ No newline at end of file
diff --git a/public/src/index.html b/public/src/index.html
index 6e2e9066c..8505394b4 100644
--- a/public/src/index.html
+++ b/public/src/index.html
@@ -23,4 +23,4 @@
 	</app-root>
 </body>
 
-</html>
+</html>
\ No newline at end of file