fix: CE-1276 1277 stored filter fixes #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikevespi
commented
Nov 27, 2024
| @@ -93,6 +92,7 @@ export const ComplaintFilter: FC<Props> = ({ type }) => { | |||
| end.setMilliseconds(999); | |||
| } | |||
|
|
|||
| setFilter("startDate", start); | |||
There was a problem hiding this comment.
This change didn't seem to be affecting the bug but I stumbled across it and it seems like if we're setting the time on start we should do so before setting the startDate filter.
afwilcox
requested changes
Nov 27, 2024
afwilcox
requested changes
Nov 27, 2024
|
afwilcox
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed persistence bugs in the search when returning to the complaints page.
Description
Fixed the date filters to get parsed into state in the complaint filters provider. This prevents the app from entering a broken state when loading a fresh complaint filter context with stored start or end date filters in the search params.
Fixed the map search function to now set the complaint search parameters in state. This fixes the bug of filters set in map not setting the complaint search parameters.
Fixes:
https://env-ceds.atlassian.net/jira/software/c/projects/CE/boards/4?selectedIssue=CE-1276
https://env-ceds.atlassian.net/jira/software/c/projects/CE/boards/4?selectedIssue=CE-1277
How Has This Been Tested?
Tested by following the steps to reproduce in the bug cards and ensuring that the site remained in a functional state.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: