feat: CE-1045 add action taken filter for ceeb #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Action Taken filter to the Complaint list for CEEB users. The filter also applies to the map view. In both the complaint search and map search, if and only if the filters contain an Action Taken, a call to the Case Management service is made requesting the lead identifiers (which in NATCom are complaint identifiers) of all leads belonging to a case_file that has had the specified action taken on it. If the list is not empty, we add an AND clause to the search to filter the results against the list. If the list is empty then the search should return no results, however SQL errors if you pass an empty list to an IN. To avoid this, a list of a single value that is not a valid complaint identifier is passed in its stead, giving the desired result.
mikevespi
added
the
case_management_1
afwilcox
requested changes
Oct 16, 2024
afwilcox
reviewed
Oct 16, 2024
mikevespi
removed
the
case_management_1
afwilcox
reviewed
Oct 17, 2024
|
afwilcox
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a filter on Action Taken to the complaints list filters for CEEB users. If the filter is is present the search function will send a request to case management for a list of
complaint_identifiers (in CM this is found through case_file -> lead_identifier via the newgetLeadsByActionTaken). These are then used to filter the complaints via an AND WHERE...IN condition. If nolead_identifiers are returned, then an array of[-1]is passed in its place, since WHERE...IN() causes an error in postgres with an empty set.Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Testing included manually testing the filter in both the complaint list, and map view. A Cypress test was added, however at the time of writing this there is no seed data in Case Management, so setup for the test (assigning an action taken to a complaint so that there is something to show up once the filter is applied) takes place in the test itself, which is not ideal.
When manually testing, if no results show after filtering, clear the filter, go into one of the actions and set an action taken, then try again.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: