Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-550- modal-improvements-V2 #703

Merged

Conversation

dmitri-korin-bcps
Copy link
Contributor

@dmitri-korin-bcps dmitri-korin-bcps commented Oct 11, 2024

Description

This PR is to standardize and improve modal dialog boxes in the UI

Fixes # (CE-550)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Perform the following actions. They will cause various modals to open. Check if the modals meet the ticket's acceptance criteria:
  • Assign an officer to a complaint
  • Try to edit a complaint and click cancel
  • Try to update complaint status and click cancel
  • Add authorization to a CEEB complaint, then try to delete it and click cancel
  • Add equipment to HWCR, try to delete it and click cancel
  • Add a note to complaint, then try to delete it and click cancel
  • Add an animal to HWCR complaint then try edit it and click cancel
  • Try to delete an animal from a complaint and click cancel

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just need to make the one adjustment to remove the outlines around the officers in the assign modal as per demo feedback

Copy link

@afwilcox afwilcox merged commit a788f68 into release/lions-mane-jellyfish Oct 15, 2024
15 checks passed
@afwilcox afwilcox deleted the feat/CE-550-MODAL-Improvements-v2 branch October 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants