diff --git a/client/pom.xml b/client/pom.xml index 0744b9a611..f8cb0789b4 100644 --- a/client/pom.xml +++ b/client/pom.xml @@ -4,7 +4,7 @@ 4.0.0 ca.bc.gov.nrs.wfnews wfnews-parent - 2.3.8 + 2.3.9 pom wfnews-parent diff --git a/client/wfnews-ear/pom.xml b/client/wfnews-ear/pom.xml index 64b992eab1..f678cf33b1 100644 --- a/client/wfnews-ear/pom.xml +++ b/client/wfnews-ear/pom.xml @@ -3,7 +3,7 @@ ca.bc.gov.nrs.wfnews wfnews-parent - 2.3.8 + 2.3.9 wfnews-ear ear diff --git a/client/wfnews-war/pom.xml b/client/wfnews-war/pom.xml index 5b6e4154f6..772d2d9dfd 100644 --- a/client/wfnews-war/pom.xml +++ b/client/wfnews-war/pom.xml @@ -5,7 +5,7 @@ ca.bc.gov.nrs.wfnews wfnews-parent - 2.3.8 + 2.3.9 wfnews-war war diff --git a/client/wfnews-war/src/main/angular/android/app/build.gradle b/client/wfnews-war/src/main/angular/android/app/build.gradle index ea533cdd99..d2e8620df9 100644 --- a/client/wfnews-war/src/main/angular/android/app/build.gradle +++ b/client/wfnews-war/src/main/angular/android/app/build.gradle @@ -11,7 +11,7 @@ android { minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion versionCode 155 - versionName "2.3.8" + versionName "2.3.9" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" aaptOptions { // Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps. diff --git a/client/wfnews-war/src/main/angular/package.json b/client/wfnews-war/src/main/angular/package.json index 5558f0660a..7b98688de7 100644 --- a/client/wfnews-war/src/main/angular/package.json +++ b/client/wfnews-war/src/main/angular/package.json @@ -1,6 +1,6 @@ { "name": "wildfire", - "version": "2.3.8", + "version": "2.3.9", "license": "MIT", "engines": { "node": "^18.16.0" diff --git a/client/wfnews-war/src/main/angular/src/assets/data/appConfig.json b/client/wfnews-war/src/main/angular/src/assets/data/appConfig.json index cbf8861208..1e9c30b4d9 100644 --- a/client/wfnews-war/src/main/angular/src/assets/data/appConfig.json +++ b/client/wfnews-war/src/main/angular/src/assets/data/appConfig.json @@ -2,7 +2,7 @@ "application": { "wfnewsApiKey": "fake-api-key", "acronym": "WFNEWS", - "version": "2.3.8-SNAPSHOT", + "version": "2.3.9-SNAPSHOT", "buildNumber": ".0000", "environment": "LOCAL", "baseUrl": "http://localhost:6200/", diff --git a/server/wfnews-api/wfnews-service-api/pom.xml b/server/wfnews-api/wfnews-service-api/pom.xml index 781643e72c..292de831fd 100644 --- a/server/wfnews-api/wfnews-service-api/pom.xml +++ b/server/wfnews-api/wfnews-service-api/pom.xml @@ -29,7 +29,7 @@ ca.bc.gov.nrs.wfim wfim-incidents-api-rest-common - 1.5.0-SNAPSHOT + 1.9.5-SNAPSHOT org.postgresql diff --git a/server/wfone-notifications-api/wfone-notifications-quartz-scheduler/pom.xml b/server/wfone-notifications-api/wfone-notifications-quartz-scheduler/pom.xml index 19c7564547..cbcb8f6a49 100644 --- a/server/wfone-notifications-api/wfone-notifications-quartz-scheduler/pom.xml +++ b/server/wfone-notifications-api/wfone-notifications-quartz-scheduler/pom.xml @@ -62,7 +62,7 @@ ca.bc.gov.nrs.wfim wfim-incidents-api-rest-common - 1.6.1 + 1.9.5-SNAPSHOT diff --git a/server/wfone-notifications-api/wfone-notifications-service-api/pom.xml b/server/wfone-notifications-api/wfone-notifications-service-api/pom.xml index e2ee41e4de..7ae27129dd 100644 --- a/server/wfone-notifications-api/wfone-notifications-service-api/pom.xml +++ b/server/wfone-notifications-api/wfone-notifications-service-api/pom.xml @@ -22,7 +22,7 @@ ca.bc.gov.nrs.wfim wfim-incidents-api-rest-common - 1.6.1 + 1.9.5-SNAPSHOT diff --git a/server/wfone-notifications-api/wfone-notifications-service-api/src/main/java/ca/bc/gov/nrs/wfone/service/api/v1/impl/RecordRoFServiceImpl.java b/server/wfone-notifications-api/wfone-notifications-service-api/src/main/java/ca/bc/gov/nrs/wfone/service/api/v1/impl/RecordRoFServiceImpl.java index 951bfaabf4..bc75eaa783 100644 --- a/server/wfone-notifications-api/wfone-notifications-service-api/src/main/java/ca/bc/gov/nrs/wfone/service/api/v1/impl/RecordRoFServiceImpl.java +++ b/server/wfone-notifications-api/wfone-notifications-service-api/src/main/java/ca/bc/gov/nrs/wfone/service/api/v1/impl/RecordRoFServiceImpl.java @@ -116,10 +116,6 @@ public class RecordRoFServiceImpl implements RecordRoFService { EmailNotificationService emailNotificationService; private Date codeTableRefresh; - private String visibleFlameString = "Visible Flames = Yes; "; - private String noVisibleFlameString = "Visible Flames = No; "; - private String noCommentVisibleFlameString = "Visible Flames = N/C; "; - private String noCommentString = "No comments"; private FileService fileService; private CodeTableListRsrc codeTables; private Properties applicationProperties; @@ -574,26 +570,18 @@ private String prepareRoF(JSONObject rofFormDataJson, ObjectMapper mapper) rof.setSubmittedTimestamp(Date.from(submittedDateTime.atZone(ZoneId.systemDefault()).toInstant())); } - // set default visible flame string as No Comment - String visibleFlame = noCommentVisibleFlameString; - - if (rofFormDataJson.has("visibleFlame") && rofFormDataJson.optJSONArray("visibleFlame") != null) { - if (rofFormDataJson.optJSONArray("visibleFlame").isEmpty()) { - visibleFlame = noCommentVisibleFlameString; - } else if (rofFormDataJson.getJSONArray("visibleFlame").toString().replace("[", "").replace("]", "") - .replace("\"", "").equalsIgnoreCase("YES")) { - visibleFlame = visibleFlameString; - } else if (rofFormDataJson.getJSONArray("visibleFlame").toString().replace("[", "").replace("]", "") - .replace("\"", "").equalsIgnoreCase("NO")) { - visibleFlame = noVisibleFlameString; - } - } + Boolean visibleFlame = rofFormDataJson.has("visibleFlame") + && rofFormDataJson.optJSONArray("visibleFlame") != null + && rofFormDataJson.getJSONArray("visibleFlame").toString() + .replace("[", "").replace("]", "") + .replace("\"", "") + .equalsIgnoreCase("YES"); + rof.setFlamesVisibleInd(visibleFlame); - if (rofFormDataJson.has("otherInfo") && !rofFormDataJson.optString("otherInfo", "").equals("")) - rof.setCallerReportDetails(visibleFlame + rofFormDataJson.optString("otherInfo")); - else if (rofFormDataJson.has("otherInfo") && rofFormDataJson.optString("otherInfo", "").equals("")) - rof.setCallerReportDetails(visibleFlame + noCommentString); + if (rofFormDataJson.has("otherInfo") && !rofFormDataJson.optString("otherInfo", "").isEmpty()) { + rof.setCallerReportDetails(rofFormDataJson.optString("otherInfo")); + } logger.info(" ### START POST - Serializing and executing RoF POST..."); mapper.activateDefaultTyping(mapper.getPolymorphicTypeValidator(), ObjectMapper.DefaultTyping.JAVA_LANG_OBJECT,