Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INV-3763] WhatsHere Actions -> ActionCreators #3764

Closed
wants to merge 25 commits into from
Closed

[INV-3763] WhatsHere Actions -> ActionCreators #3764

wants to merge 25 commits into from

Conversation

LocalNewsTV
Copy link
Collaborator

Overview

Important

This PR Is forked off of PR #3762 which is currently unmerged (as of 2024-30-12).
This PR Will remain in a Draft state until merge

This PR includes the following proposed change(s):

  • Convert WhatsHere functionality from Actions to ActionCreators
  • Remove failure action, as is unused aside from firing.
  • Cleanup reducers/map.ts reducing object drilling through use of destructuring / Object.assign. Improving readability of the code.
  • Closes Convert WhatsHere / Activity actions to ActionCreators #3763

@LocalNewsTV
Set default Recordset name as '', put old default as falsey placeholder
57b4955
@LocalNewsTV
remove logic that would block cache button from IAPP recordsets
86dfad6
@LocalNewsTV
Update/add stub interfaces for Iapp and Activity
4f5a4b0
@LocalNewsTV
Stub methods, parse json parse records in their promises
2827734
@LocalNewsTV
Add caching functionality for IAPP
d5fe524
@LocalNewsTV
Correct label for cached IAPP records
755a518
@LocalNewsTV
Implement createOfflineIappLayer, simplify workflow
6a02a87
@LocalNewsTV
remove stale log
58fd1ea
@LocalNewsTV
Force cast IAPP Ids as strings
ae07072
@LocalNewsTV
disable Asc/desc buttons on RecordTable when offline IAPP
8945886
@LocalNewsTV
Offline workflow to populate IAPP Records, destructure action.payload
583d526
@LocalNewsTV
remove unused offline actions
67c5a72
@LocalNewsTV
delete all actions that are not imported outside of actions.ts
d2eec4d
@LocalNewsTV
Add IappActions class
9998d6d
@LocalNewsTV
Add abstract loadIapp() to RecordCache class
6d36ad1
@LocalNewsTV
Refactor Iapp 'actions' to 'actionCreators'
8d166b9
@LocalNewsTV
Add Back Button to IAPP records
38c4b8b
@LocalNewsTV
Cleanup/Correct IAPP actions
17c7057
@LocalNewsTV
Modify IAPP Whats Here workflow for offline
09be7df
@LocalNewsTV
Sqlite iapp records appear on Map while offline
8be9c80
@LocalNewsTV
Cast ID lists as string for consistency between Activity/IAPP. IAPP A…
7621889 
…ppears in Tables when offline
@LocalNewsTV
Full IAPP Records load from Offline cache.
0b80f7a
@LocalNewsTV
Merge branch 'dev' into offline_iapp_records
87d9ab1
@LocalNewsTV
Convert Activity Table actions to ActionCreators
3278bf5
@LocalNewsTV
convert actions to actionCreators, simplify conditions using Object.a…
a0eba9b 
…ssign
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasticviking plasticviking Awaiting requested review from plasticviking

@meghna0593 meghna0593 Awaiting requested review from meghna0593

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert WhatsHere / Activity actions to ActionCreators
1 participant
@LocalNewsTV