[INV-3742][INV-3733][INV-3747][INV-3746] IAPP Records can Be cached and Used when Offline #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppears in Tables when offline
|
LocalNewsTV
commented
Dec 24, 2024
Comment on lines
+651
to
+700
| } else if (IappActions.getRows.match(action)) { | ||
| const { recordSetID, page, limit, tableFiltersHash } = action.payload; | ||
| draftState.recordTables[recordSetID] ??= {}; | ||
| draftState.recordTables[recordSetID].loading = true; | ||
| draftState.recordTables[recordSetID].page = page; | ||
| draftState.recordTables[recordSetID].limit = limit; | ||
| draftState.recordTables[recordSetID].tableFiltersHash = tableFiltersHash; | ||
| } else if (IappActions.getRowsSuccess.match(action)) { | ||
| { | ||
| // the hash, page, and limit all need to line up | ||
| if ( | ||
| draftState.recordTables?.[action.payload.recordSetID]?.tableFiltersHash !== action.payload.tableFiltersHash | ||
| ) { | ||
| console.warn( | ||
| 'hash mismatch', | ||
| draftState.recordTables?.[action.payload.recordSetID]?.tableFiltersHash, | ||
| action.payload.tableFiltersHash | ||
| ); | ||
| return; | ||
| } | ||
| if (Number(draftState.recordTables?.[action.payload.recordSetID]?.limit) !== Number(action.payload.limit)) { | ||
| console.warn( | ||
| 'limit mismatch', | ||
| draftState.recordTables?.[action.payload.recordSetID]?.limit, | ||
| action.payload.limit | ||
| ); | ||
| console.warn( | ||
| 'typeof', | ||
| typeof draftState.recordTables?.[action.payload.recordSetID]?.limit, | ||
| typeof action.payload.limit | ||
| ); | ||
| return; | ||
| } | ||
| if (Number(draftState.recordTables?.[action.payload.recordSetID]?.page) !== Number(action.payload.page)) { | ||
| console.warn( | ||
| 'page mismatch', | ||
| draftState.recordTables?.[action.payload.recordSetID]?.page, | ||
| action.payload.page | ||
| ); | ||
| return; | ||
| } | ||
| if (draftState.recordTables?.[action.payload.recordSetID]) { | ||
| draftState.recordTables[action.payload.recordSetID].rows = action.payload.rows; | ||
| } else { | ||
| draftState.recordTables[action.payload.recordSetID] = {}; | ||
| draftState.recordTables[action.payload.recordSetID].rows = action.payload.rows; | ||
| } // set defaults | ||
| draftState.recordTables[action.payload.recordSetID].loading = false; | ||
| return; | ||
| } |
There was a problem hiding this comment.
Pre-existing code. Just migrated from Switch to if-else block during the actionCreator conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes the following proposed change(s):
Tip
This work runs parallel to the previously broken down work for
Activitytype Records for PR's #3738, #3752Note
IAPP Records are created by two network requests with separate payload. One for when showing the Tabular data, and the second for showing the records. This is why there's a distinction When sharing / loading the types of records to display.
Add a
Backbutton to IAPP records because they are read-onlyCreate type aliases for
IappTableRowandIappRecord.Break down
recordset-layers.tsfurther, reducing cognitive complexity.Convert IAPP and
WhatsHere[iapp]actions into ActionCreators in line with recent refactoringremove all
actions.tsactions that were not imported anywhere.Add ability to Cache
IAPPRecordsetsAdd ability to Used Cached IAPP Records in
Whats HereWhats Here#3747Add ability to Show cached IAPP Records on the map in Offline context
Set Default Recordset named to an empty string. When recordset is unnamed, show the Default text
New Recordset - [type]