-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INV-3685][INV-3732][INV-3678] Show Map Markers with Cached Recordsets, hide default recordsets from caching #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/UI/Map2/Map.tsx
Outdated
@@ -51,7 +52,7 @@ export const Map = ({ children }) => { | |||
|
|||
const [draw, setDraw] = useState(null); | |||
const [mapReady, setMapReady] = useState(false); | |||
|
|||
const [loggedIn, setLoggedIn] = useState<boolean>(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we put this in the redux store -- something like loggedInOrWorkingOffline
. We probably use this in multiple places.
…fline mutually exclusive
LocalNewsTV
force-pushed
the
3685-offline-map-recordset-markers-2
branch
from
December 12, 2024 16:27
51d3a2f
to
0969b13
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes the following proposed change(s):
[INV-3685]
Cached recordsets now show on Map when user is offline, Label functionality also enabled
When using
Offline User
Force them into offline modeMap.tsx
modified to differentiate between anauthenticated
user from aloggedIn
user.Added functionality to strip layers off the map when going from online -> offline context to populate Caches
Reworked
recordset-layers.tsx
to be more DRY by turning layer declarations into modifiable functions, promoting reusabilityCloses Mobile: Cached recordsets not visible on map #3685
[INV-3732][INV-3678] Disable
Default
Recordsets from being eligible for CachingMisc
forEach
instead ofmap
, simplifying logic flows