Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: BCGW layer doesn't work for Mobile #3736

Closed
wants to merge 3 commits into from
Closed

WIP: BCGW layer doesn't work for Mobile #3736

wants to merge 3 commits into from

Conversation

meghna0593
Copy link
Collaborator

@meghna0593 meghna0593 commented Dec 5, 2024 •
edited
Loading

Overview

This PR includes the following proposed change(s):

  • Proxy to hit the openmaps endpoint to avoid cors issue
  • Changes on the frontend to cater to this api

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

@meghna0593 meghna0593 linked an issue Dec 5, 2024 that may be closed by this pull request
Mobile: BCGW (BC Geographic Warehouse) layers not visible on map when turned on #3632
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

LocalNewsTV
LocalNewsTV reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things
Think this would need a proper test on a physical device ( that I don't have ) to properly sign off on :)

api/src/paths/proxy/openmaps.ts Show resolved Hide resolved
api/src/paths/proxy/openmaps.ts Show resolved Hide resolved
app/src/UI/Map2/LayerPicker/LpLayers/LpLayers.tsx Show resolved Hide resolved
app/src/UI/Map2/helpers/map-init.ts Show resolved Hide resolved
api/src/paths/proxy/openmaps.ts Show resolved Hide resolved
@meghna0593
Copy link
Collaborator Author

meghna0593 commented Dec 5, 2024 •
edited
Loading

Just a few minor things Think this would need a proper test on a physical device ( that I don't have ) to properly sign off on :)

Good point, I'll ask Brennan to test it out :D

@meghna0593 meghna0593 closed this Dec 5, 2024
@meghna0593 meghna0593 removed a link to an issue Dec 24, 2024
Mobile: BCGW (BC Geographic Warehouse) layers not visible on map when turned on #3632
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV left review comments

@plasticviking plasticviking Awaiting requested review from plasticviking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghna0593 @LocalNewsTV