-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INV-3576][INV-3488] Use of Recordsets when offline #3714
Merged
plasticviking
merged 19 commits into
dev
from
3576-3488-block&use-recordsets-while-offline
Nov 27, 2024
Merged
[INV-3576][INV-3488] Use of Recordsets when offline #3714
plasticviking
merged 19 commits into
dev
from
3576-3488-block&use-recordsets-while-offline
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalNewsTV
changed the title
[INV-3576] Limit Cache Records when Offline | [INV-3488] Use Cached Records when Offline
[INV-3576][INV-3488] Use of Recordsets when offline
Nov 27, 2024
LocalNewsTV
force-pushed
the
3576-3488-block&use-recordsets-while-offline
branch
from
November 27, 2024 00:18
8fe0765
to
7dd37f0
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes the following proposed change(s):
Important
If you start the application offline by default you won't be able open a cached recordset because unrelated functions are not resolving. This is not part of this work.
#3488
/Records
andLayer Picker
filterRecordsetsByNetworkState()
to filter records#3576
UserRecordSet
's cacheMetadatafetchPaginatedCachedRecords()
in RecordCacheService to populate tables when offline (Uses the cache)UserRecord
interface to help with future typing instead of theRecord<string,any>
we've been using in the meantimehandle_ACTIVITIES_GEOJSON_GET_REQUEST()
that integrates into success handlerRecordTableHandlers.tsx
to handle subtle differences in displaying online records vs cached recordsMisc Cleanup Tasks
React.Fragment
/Records
to 0 would evaluate as false and throw an error