Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INV-3672] Linked ID showing improperly #3673

Merged
merged 5 commits into from
Nov 18, 2024
Merged

[INV-3672] Linked ID showing improperly #3673

merged 5 commits into from
Nov 18, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Nov 14, 2024 •
edited
Loading

Overview

This PR includes the following proposed change(s):

  • Initial bug was New activities firing LinkedID calls when creating a new record and a geography had not been set
    • Blocked calls when shape doesn't exist.
  • Moved component into own widget, separating from the existing catch-all SingleSelectAutoComplete.tsx
    • Removed object drilling that occurs with Linked_Id state in the reduce
    • Create LinkedIdSelectAutoComplete.tsx to handle the state of the widget
  • Correct max-height attribute for AgentSelectAutoComplete for tidiness.
  • Correct text in Alert
  • Closes Short ID's showing improperly #3672

LocalNewsTV
LocalNewsTV commented Nov 14, 2024
View reviewed changes
app/src/rjsf/widgets/AgentSelectAutoComplete.tsx
Comment on lines +89 to +93
SelectProps={{
MenuProps: {
sx: { height: '300px' }
}
}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended, due to MUI instability

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
37.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@plasticviking plasticviking merged commit 61968b9 into dev Nov 18, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasticviking plasticviking Awaiting requested review from plasticviking

@meghna0593 meghna0593 Awaiting requested review from meghna0593

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short ID's showing improperly
2 participants
@LocalNewsTV @plasticviking