Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INV-3641] Cleanup MultiSelectAutoComplete #3657

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[INV-3641] Cleanup MultiSelectAutoComplete #3657

merged 1 commit into from
Nov 13, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Nov 7, 2024 •
edited
Loading

Overview

This PR includes the following proposed change(s):

  • Adjust Styling for MultiSelectAutoComplete.tsx
  • Given its a less stable Mui component, we have to do the styling in the component instead of in a separate .css file. So work was continued with adjusting the existing styling
  • Convert Colors into an enum instead of parsing multiple hex values
  • Remove unneeded variables
  • Closes ⚡ Refactor MultiSelectAutocomplete.tsx #3641

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@plasticviking plasticviking merged commit 986a39e into dev Nov 13, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasticviking plasticviking Awaiting requested review from plasticviking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ Refactor MultiSelectAutocomplete.tsx
2 participants
@LocalNewsTV @plasticviking