Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3637] PARTIAL** Mobile Friendly changes #3652

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Nov 5, 2024

Overview

This is partial work towards the completion of #3637

This PR includes the following proposed change(s):

Viewport was set to Galaxy S20

  1. Widen the header to better use screen space
    • Flip Network icons horizontal instead of stacked. They're too large to fit in pre-existing header size.
    • switch outer div to header given its a header
    • CSS cleanup
  2. Refactor Map Buttons to not overflow out and disappear
    • CSS Adjustments only
  3. Recordset lists
    • Break /Records into sub components
    • Split into two main subcomponents
    • In Mobile widths, stack them to avoid compression
    • Editing a recordset name doesn't toggle them all into edit mode
    • Reduce logic complexity in what is supposed to render and when

Pictures

  1. Widening Header

New

image

Old

image

  1. Map Buttons

New

image

Old

This as far left as you can scroll, given context, buttons become unusable, rightmost button is eclipsed by map details

image

  1. Recordsets

Old

image
image

New

image

@LocalNewsTV
Copy link
Collaborator Author

Both Sonarcloud issues are pre-existing prior to this work

Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@plasticviking plasticviking merged commit d0d57e1 into dev Nov 6, 2024
5 of 9 checks passed
@LocalNewsTV LocalNewsTV deleted the 3637-mobile-friendly branch November 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants