Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv stream s3 #2961

Merged
merged 8 commits into from
Nov 2, 2023
Merged

csv stream s3 #2961

merged 8 commits into from
Nov 2, 2023

Conversation

gdalcengio
Copy link
Contributor

  • WIP POC, stream csv generator to s3
  • Prepare signed url for streamed csvs
  • WIP Fix naming convention, properly send data through to frontend with s3 CSV
  • Change csv buttons to s3 links on generation
  • Add download link button for specific record set's csv link
  • Get IAPP CSV link download working with small datasets
  • Add loading spinner to CSV streaming button
  • Fix the large file issue with CSV streaming

Overview

This PR includes the following proposed change(s):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots if applicable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@micheal-w-wells micheal-w-wells merged commit 9e56f66 into dev Nov 2, 2023
1 check passed
Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
13.2% 13.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@micheal-w-wells micheal-w-wells deleted the csv_stream_s3 branch November 7, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants