Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INSPECT-333][FEATURE] feat: updated conditional field about drain plugs #344

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[INSPECT-333][FEATURE] feat: updated conditional field about drain plugs #344

merged 1 commit into from
Dec 23, 2024
+16 −13

Conversation

PaulGarewal
Copy link
Contributor

@PaulGarewal PaulGarewal commented Dec 23, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • when first drainplug field toggled to false, second will also be false in all scenarios (confirmed in database)
  • updated emojis for a cleaner ui experience

@PaulGarewal
feat: updated conditional field about drain plugs
2ad0fa3 
- when first drainplug field toggled to false, second will also be false in all scenarios
- updated emojis for a cleaner ui experience
@PaulGarewal PaulGarewal requested a review from a team December 23, 2024 22:18
@PaulGarewal PaulGarewal self-assigned this Dec 23, 2024
@PaulGarewal PaulGarewal linked an issue Dec 23, 2024 that may be closed by this pull request
Update to Conditional Fields about Drain Plugs #333
Closed
dallascrichmond
dallascrichmond approved these changes Dec 23, 2024
View reviewed changes
Copy link

@dallascrichmond dallascrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulGarewal PaulGarewal merged commit ffe5f60 into master Dec 23, 2024
3 checks passed
@PaulGarewal PaulGarewal deleted the 333-update-conditional-fields branch December 23, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallascrichmond dallascrichmond dallascrichmond approved these changes

Assignees

@PaulGarewal PaulGarewal

Labels
Frontend GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Conditional Fields about Drain Plugs
2 participants
@PaulGarewal @dallascrichmond