[INSPECT-340][FEATURE] - added scroll feature to validation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added emojis to validation errors - created new alert for validation message in inspection
5 tasks
PaulGarewal
commented
Dec 20, 2024
| alertVC.modalTransitionStyle = .crossDissolve | ||
| alertVC.configure(title: title, message: message) | ||
| topVC.present(alertVC, animated: true) | ||
| } |
There was a problem hiding this comment.
This is the function to render our inspection validation with the scroll ability
PaulGarewal
commented
Dec 20, 2024
| @@ -0,0 +1,95 @@ | |||
| // | |||
There was a problem hiding this comment.
Had to create a new class for this new alert message, rather than edit the existing class.
PaulGarewal
commented
Dec 20, 2024
| var message: String = "" | ||
| guard let model = self.model else { return message } | ||
| var counter = 1 | ||
| var messages: [String] = [] |
There was a problem hiding this comment.
This file is general clean up and the adding of the emojis to the error messages
PaulGarewal
commented
Dec 20, 2024
| @@ -209,7 +209,7 @@ class WatercraftInspectionViewController: BaseViewController { | |||
| if canSubmit() { | |||
| self.navigationController?.popViewController(animated: true) | |||
There was a problem hiding this comment.
Another clean up and adding emojis
PaulGarewal
commented
Dec 20, 2024
| @@ -145,3 +145,21 @@ extension UIViewController { | |||
| return alert | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This helps show alerts regardless of navigation stack (helped to display our alert box in each window)
fergmac
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Standards
HOTFIX,FEATURE,etc][INSPECT-###]Description
This PR includes the following proposed change(s):
Simulator.Screen.Recording.-.iPad.10th.generation.-.2024-12-20.at.07.08.25.mp4