Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar (stepper) to be consistent and indicate my steps as a form designer. #1017

Merged
merged 30 commits into from
Sep 27, 2023
Merged

Progress bar (stepper) to be consistent and indicate my steps as a form designer. #1017

merged 30 commits into from
Sep 27, 2023

Conversation

timisenco2015
Copy link
Contributor

Description

As a form owner/designer, I want the progress bar to be consistent and indicate my steps, so I always know where I am.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@timisenco2015
re-design v-stepper in Create.vue
ecec3d1
@timisenco2015
Re-design v-stepper in Create.vue
9f5d5b0
@timisenco2015
Merge branch 'ayobami-formulator-ability-for-save-export-import-funct…
712e1b5 
…ions-accessible-publish-button' of https://github.com/timisenco2015/common-hosted-form-service into ayobami_forms-97_FormDesign_Progress_Bar_backup
@timisenco2015
Working on progress bar for form design
9fe290f
@timisenco2015
work on stepper or progress bar in design.vue. Also did code clean up
8459651
@timisenco2015
Merge branch 'master' of https://github.com/timisenco2015/common-host…
783ae6e 
…ed-form-service into ayobami_forms-97_FormDesign_Progress_Bar_test
@timisenco2015
Merge branch 'master' of https://github.com/timisenco2015/common-host…
47f3714 
…ed-form-service into ayobami_forms-97_FormDesign_Progress_Bar_test
@timisenco2015
update branch with origin master
ee5fa5d
@timisenco2015
fix: translation issue in both Create.vue and Design.vue
964693a
@timisenco2015
fix: translation issue in both Create.vue and Design.vue
0607bd5
@timisenco2015
Merge branch 'master' of https://github.com/timisenco2015/common-host…
01334b7 
…ed-form-service into forms_670_FormDesign_Progress_Bar
@timisenco2015
Merge branch 'master' of https://github.com/timisenco2015/common-host…
8669818 
…ed-form-service into forms_670_FormDesign_Progress_Bar
@timisenco2015
Progress bar (stepper) to be consistent and indicate my steps as a fo…
bf698ad 
…rm designer.

Progress bar (stepper) to be consistent and indicate my steps as a form designer.
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

Coverage Report (Application)

Totals Coverage
Statements: 41.36% ( 2566 / 6204 )
Methods: 36.29% ( 315 / 868 )
Lines: 46.81% ( 1710 / 3653 )
Branches: 32.14% ( 541 / 1683 )

@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 68.6% ( 1090 / 1589 )
Methods: 65.42% ( 193 / 295 )
Lines: 73.12% ( 767 / 1049 )
Branches: 53.06% ( 130 / 245 )

@timisenco2015 timisenco2015 marked this pull request as draft September 18, 2023 18:59
@timisenco2015
Not working commit
fd682db
@timisenco2015
Not working commit
5340cd0
@timisenco2015
Fix: add PublishForm.vue to the progress stepper
d92f603 
- add PublishForm.vue to the progress stepper
- remove unused codes
- ensure that all changes pass the test
@timisenco2015
add PublishForm.vue to the progress stepper
2b5f3a3 
add PublishForm.vue to the progress stepper
@timisenco2015
Merge branch 'master' of https://github.com/timisenco2015/common-host…
8411c31 
…ed-form-service into Forms_670-progress_bar_to_be_consitent_and_indicate_my_steps
@timisenco2015
update branch with stream master branch
ce23ed9 
update branch with stream master branch
@timisenco2015
fix: fix an issue with the publish confirmation popup (#1042)
3527133
@timisenco2015
Merge branch 'master' into Forms_670-progress_bar_to_be_consitent_and…
bc9b0a0 
…_indicate_my_steps
@timisenco2015
fix: adjust stepper width
da4d31b
@timisenco2015
Update BaseStepper.vue
3802874
@timisenco2015
fix: v-stepper-step padding
a665faa
@timisenco2015 timisenco2015 marked this pull request as ready for review September 26, 2023 21:42
WalterMoar

This comment was marked as resolved.

Sign in to view

@timisenco2015

This comment was marked as resolved.

Sign in to view
@timisenco2015 timisenco2015 merged commit 798ef25 into master Sep 27, 2023
11 checks passed
@timisenco2015 timisenco2015 deleted the Forms_670-progress_bar_to_be_consitent_and_indicate_my_steps branch September 27, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterMoar WalterMoar WalterMoar approved these changes

@bcvesalink bcvesalink Awaiting requested review from bcvesalink

@jasonchung1871 jasonchung1871 Awaiting requested review from jasonchung1871

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timisenco2015 @WalterMoar