New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ckeditor with vuetify textarea #35

Merged

jatindersingh93 merged 1 commit into master from html-editor

Apr 16, 2024

Contributor

TimCsaky commented Apr 11, 2024

Description

replaced ckeditor with the textarea component that comes with Vuetify
UX is better, user just pastes in html code (from provided example files)
reduces our npm package vulnerabilities

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have read the CONTRIBUTING doc
I have checked that unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Further comments

TimCsaky requested review from jatindersingh93 and norrisng-bc

April 11, 2024 19:49

github-actions bot commented Apr 11, 2024

Coverage Report (Application)

Totals
Statements:	69.5% ( 180 / 259 )
Methods:	60.61% ( 20 / 33 )
Lines:	75.28% ( 134 / 178 )
Branches:	54.17% ( 26 / 48 )

github-actions bot commented Apr 11, 2024

Coverage Report (Frontend)

Totals
Statements:	28.94% ( 112 / 387 )
Methods:	31.48% ( 34 / 108 )
Lines:	32.09% ( 60 / 187 )
Branches:	19.57% ( 18 / 92 )


          replace ckeditor with vuetify textarea

ea3ab75

TimCsaky force-pushed the html-editor branch from 572b55e to ea3ab75 Compare

April 11, 2024 21:00

jatindersingh93 approved these changes

View reviewed changes

jatindersingh93 merged commit d762a0f into master

18 of 19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet