Add klamm service and controller for requesting rule info. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwekkenbc
approved these changes
Dec 13, 2024
src/api/klamm/klamm.service.ts
Outdated
Comment on lines
76
to
83
| async getKlammBRERules(): Promise<string[]> { | ||
| try { | ||
| const { data } = await this.axiosKlammInstance.get(`${process.env.KLAMM_API_URL}/api/brerules`); | ||
| return data; | ||
| } catch (err) { | ||
| throw new HttpException('Error fetching from Klamm', HttpStatus.INTERNAL_SERVER_ERROR); | ||
| } | ||
| } |
There was a problem hiding this comment.
_getAllKlammFields already does this. Maybe remove that method and have the code call this one instead?
There was a problem hiding this comment.
Feel silly for missing this! Thank you, will update.
There was a problem hiding this comment.
Removed the duplication and updated BRM App PR bcgov/brm-app#56 to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API support for bcgov/brm-app#56.
Pulls all rules from the Klamm bre rules endpoint.