Improved initial dev experience for mongodb #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timwekkenbc
commented
Nov 13, 2024
timwekkenbc
commented
- Created a docker-compose file for creating a mongodb database
- Added a file to seed this initial database with some data
- Updated the README
timwekkenbc
force-pushed
the
feature/improve-dev-mongodb-experience
branch
from
24c56a9 to
a56b4b5
Compare
brysonjbest
approved these changes
Nov 13, 2024
src/api/klamm/klamm.service.ts
Outdated
There was a problem hiding this comment.
I find it useful in testing to have it synced to my local klamm. Is there a reason to remove this from the local production? I'm not sure what the env for the development environment is, but does this also remove this function from there by restricting it to production?
There was a problem hiding this comment.
Good point. I forgot about local Klamm. I was just thinking this running was unnecessary during dev. But I'll revert that change
|
|
||
| ### Including Rules from the Rules Repository | ||
|
|
||
| To get access to rules locally on your machine simply clone the repo at https://github.com/bcgov/brms-rules into your project. This project is set to grab rules from `brms-rules/rules`, which is the default location of rules if that project is cloned into this one. |
There was a problem hiding this comment.
it might be pedantic, but would we want to include the clone instructions directly here so they could be easily copy/pasted to copy into the correct directory?
…a file to seed this initial database with some data, Updated the README
timwekkenbc
force-pushed
the
feature/improve-dev-mongodb-experience
branch
from
a56b4b5 to
ff20b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.