Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-9740 HOTFIX: User is not able to update the Acquisition Files #4548

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

asanchezr
Copy link
Collaborator

The root cause was a previous attempt to fix a UTC date, which resulted in this error.
Fixed by improving how we assign default "current date" in the backend.

image

@asanchezr asanchezr added bug Something isn't working hotfix 5.7 labels Dec 21, 2024
@asanchezr asanchezr self-assigned this Dec 21, 2024
@asanchezr asanchezr changed the base branch from dev to test December 21, 2024 22:49
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

1 similar comment
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

1 similar comment
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

@eddherrera eddherrera self-requested a review December 23, 2024 20:56
@@ -121,7 +120,7 @@ export class UpdateAcquisitionSummaryFormModel
newForm.legacyFileNumber = model.legacyFileNumber ?? undefined;
newForm.fileName = model.fileName || '';
newForm.rowVersion = model.rowVersion ?? undefined;
newForm.assignedDate = model.assignedDate ? formatUTCDateTime(model.assignedDate) : '';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't his going to bring back the issue of the time zone?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope because if you see the changes in the backend will generate the current date in the server timezone (DateTime.Today) - we have configured our API servers to run in PST timezone so we don't get the issue anymore.
The original issue happened because when this field is not populated, the DB was assigning the current UTC date.
By having the backend put a value always (either what comes from the frontend or the current date (non-UTC)) we fix this and do not need to format as UTC in the frontend.

This is consistent with the other dates you see on the acquisition details screen - none of those are formatted as UTC.

Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

1 similar comment
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4548

@asanchezr asanchezr merged commit 6362ad3 into bcgov:test Dec 23, 2024
10 checks passed
@asanchezr asanchezr deleted the psp-9740-hotfix branch December 24, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.7 bug Something isn't working hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants