Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-9488 Titles are missing on Properties links and File Summary #4456

Merged
merged 2 commits into from
Nov 7, 2024
Merged

PSP-9488 Titles are missing on Properties links and File Summary #4456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
487b22d
Titles are missing on Properties links and File Summary
asanchezr Nov 6, 2024
607b256
Update snapshots
asanchezr Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../frontend/src/features/mapSideBar/acquisition/__snapshots__/AcquisitionView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,11 @@ exports[`AcquisitionView component > renders as expected 1`] = `
<div
class="col"
>
File Summary
<span
title="File Details"
>
File Summary
</span>
</div>
<div
class="c22"
Expand Down Expand Up @@ -944,6 +948,7 @@ exports[`AcquisitionView component > renders as expected 1`] = `
>
<button
class="c3 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down Expand Up @@ -975,6 +980,7 @@ exports[`AcquisitionView component > renders as expected 1`] = `
>
<button
class="c3 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
14 changes: 10 additions & 4 deletions source/frontend/src/features/mapSideBar/acquisition/common/AcquisitionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ const AcquisitionMenu: React.FunctionComponent<
className={cx('no-gutters', { selected: props.selectedIndex === index })}
>
{activeIndex ? (
<Col>{label}</Col>
<Col>
<span title="File Details">{label}</span>
</Col>
) : (
<Col>
<LinkButton onClick={() => handleClick(index)}>{label}</LinkButton>
<LinkButton title="File Details" onClick={() => handleClick(index)}>
{label}
</LinkButton>
</Col>
)}
<StyledMenuHeaderWrapper>
Expand Down Expand Up @@ -92,10 +96,12 @@ const AcquisitionMenu: React.FunctionComponent<
</StyledIconWrapper>
</Col>
{activeIndex ? (
<Col>{label}</Col>
<Col>
<span title="View">{label}</span>
</Col>
) : (
<Col>
<LinkButton>{label}</LinkButton>
<LinkButton title="View">{label}</LinkButton>
</Col>
)}
</StyledRow>
Expand Down
1 change: 1 addition & 0 deletions source/frontend/src/features/mapSideBar/acquisition/common/GenerateForm/GenerateFormView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const GenerateFormView: React.FunctionComponent<
<LinkButton
key={`generate-form-entry-${entry.formType}`}
onClick={() => onGenerateClick(entry.formType)}
title="Generate"
>
{entry.text}
</LinkButton>
Expand Down
8 changes: 7 additions & 1 deletion ...nd/src/features/mapSideBar/acquisition/common/__snapshots__/AcquisitionMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,11 @@ exports[`AcquisitionMenu component > matches snapshot 1`] = `
<div
class="col"
>
one
<span
title="File Details"
>
one
</span>
</div>
<div
class="c2"
Expand Down Expand Up @@ -366,6 +370,7 @@ exports[`AcquisitionMenu component > matches snapshot 1`] = `
>
<button
class="c6 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down Expand Up @@ -397,6 +402,7 @@ exports[`AcquisitionMenu component > matches snapshot 1`] = `
>
<button
class="c6 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
11 changes: 1 addition & 10 deletions ...c/features/mapSideBar/acquisition/tabs/fileDetails/detail/AcquisitionSummaryView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@ import { getEmptyPerson } from '@/mocks/contacts.mock';
import { getEmptyOrganization } from '@/mocks/organization.mock';
import { ApiGen_Concepts_Person } from '@/models/api/generated/ApiGen_Concepts_Person';
import { toTypeCodeNullable } from '@/utils/formUtils';
import {
act,
cleanup,
findAllByTestId,
findByTestId,
render,
RenderOptions,
userEvent,
waitForEffects,
} from '@/utils/test-utils';
import { act, cleanup, render, RenderOptions, userEvent, waitForEffects } from '@/utils/test-utils';

import AcquisitionSummaryView, { IAcquisitionSummaryViewProps } from './AcquisitionSummaryView';

Expand Down
6 changes: 3 additions & 3 deletions ...rc/features/mapSideBar/acquisition/tabs/fileDetails/update/UpdateAcquisitionForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ import { mockNotesResponse } from '@/mocks/noteResponses.mock';
import { lookupCodesSlice } from '@/store/slices/lookupCodes';
import {
act,
fakeText,
fireEvent,
render,
RenderOptions,
screen,
userEvent,
waitFor,
screen,
waitForEffects,
fakeText,
fireEvent,
} from '@/utils/test-utils';

import { UpdateAcquisitionSummaryFormModel } from './models';
Expand Down
7 changes: 6 additions & 1 deletion .../frontend/src/features/mapSideBar/disposition/__snapshots__/DispositionView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,11 @@ exports[`DispositionView component > renders as expected 1`] = `
<div
class="col"
>
File Summary
<span
title="File Details"
>
File Summary
</span>
</div>
<div
class="c22"
Expand Down Expand Up @@ -880,6 +884,7 @@ exports[`DispositionView component > renders as expected 1`] = `
>
<button
class="c3 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
14 changes: 10 additions & 4 deletions source/frontend/src/features/mapSideBar/disposition/common/DispositionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,14 @@ const DispositionMenu: React.FunctionComponent<
className={cx('no-gutters', { selected: props.selectedIndex === index })}
>
{activeIndex ? (
<Col>{label}</Col>
<Col>
<span title="File Details">{label}</span>
</Col>
) : (
<Col>
<LinkButton onClick={() => handleClick(index)}>{label}</LinkButton>
<LinkButton title="File Details" onClick={() => handleClick(index)}>
{label}
</LinkButton>
</Col>
)}
<StyledMenuHeaderWrapper>
Expand Down Expand Up @@ -89,10 +93,12 @@ const DispositionMenu: React.FunctionComponent<
</StyledIconWrapper>
</Col>
{activeIndex ? (
<Col>{label}</Col>
<Col>
<span title="View">{label}</span>
</Col>
) : (
<Col>
<LinkButton>{label}</LinkButton>
<LinkButton title="View">{label}</LinkButton>
</Col>
)}
</StyledRow>
Expand Down
8 changes: 7 additions & 1 deletion ...nd/src/features/mapSideBar/disposition/common/__snapshots__/DispositionMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ exports[`DispositionMenu component > matches snapshot 1`] = `
<div
class="col"
>
one
<span
title="File Details"
>
one
</span>
</div>
<div
class="c2"
Expand Down Expand Up @@ -331,6 +335,7 @@ exports[`DispositionMenu component > matches snapshot 1`] = `
>
<button
class="c5 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down Expand Up @@ -362,6 +367,7 @@ exports[`DispositionMenu component > matches snapshot 1`] = `
>
<button
class="c5 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
7 changes: 6 additions & 1 deletion ...e/frontend/src/features/mapSideBar/research/__snapshots__/ResearchContainer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,11 @@ exports[`ResearchContainer component > renders as expected 1`] = `
<div
class="col"
>
File Summary
<span
title="File Details"
>
File Summary
</span>
</div>
<div
class="c22"
Expand Down Expand Up @@ -927,6 +931,7 @@ exports[`ResearchContainer component > renders as expected 1`] = `
>
<button
class="c3 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
16 changes: 12 additions & 4 deletions source/frontend/src/features/mapSideBar/research/common/ResearchMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,14 @@ const ResearchMenu: React.FunctionComponent<
</StyledIconWrapper>
</Col>
{props.selectedIndex === index ? (
<Col>{label}</Col>
<Col>
<span title="View">{label}</span>
</Col>
) : (
<Col>
<LinkButton onClick={() => handleClick(index)}>{label}</LinkButton>
<LinkButton title="View" onClick={() => handleClick(index)}>
{label}
</LinkButton>
</Col>
)}
</>
Expand All @@ -52,10 +56,14 @@ const ResearchMenu: React.FunctionComponent<
{index === 0 && (
<>
{props.selectedIndex === index ? (
<Col>{label}</Col>
<Col>
<span title="File Details">{label}</span>
</Col>
) : (
<Col>
<LinkButton onClick={() => handleClick(index)}>{label}</LinkButton>
<LinkButton title="File Details" onClick={() => handleClick(index)}>
{label}
</LinkButton>
</Col>
)}
<StyledMenuHeaderWrapper>
Expand Down
8 changes: 7 additions & 1 deletion ...frontend/src/features/mapSideBar/research/common/__snapshots__/ResearchMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,11 @@ exports[`ResearchMenu component > renders as expected when provided no research
<div
class="col"
>
First label
<span
title="File Details"
>
First label
</span>
</div>
<div
class="c2"
Expand Down Expand Up @@ -366,6 +370,7 @@ exports[`ResearchMenu component > renders as expected when provided no research
>
<button
class="c6 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down Expand Up @@ -397,6 +402,7 @@ exports[`ResearchMenu component > renders as expected when provided no research
>
<button
class="c6 Button btn btn-link"
title="View"
type="button"
>
<div
Expand Down
Loading