Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7204 : FT: Logic for Completing Takes - When a property belongs to different files, the pin colour doesn't obey the established priority #3584

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

eddherrera
Copy link
Collaborator

No description provided.

@eddherrera eddherrera added the bug Something isn't working label Nov 9, 2023
@eddherrera eddherrera self-assigned this Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #3584 (695d86c) into dev (61df913) will decrease coverage by 6.18%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3584      +/-   ##
==========================================
- Coverage   69.59%   63.41%   -6.18%     
==========================================
  Files        1371      473     -898     
  Lines       33865    15260   -18605     
  Branches     6297     1037    -5260     
==========================================
- Hits        23568     9677   -13891     
+ Misses      10044     5329    -4715     
- Partials      253      254       +1     
Flag Coverage Δ
unittests 63.41% <28.57%> (-6.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rce/backend/dal/Repositories/PropertyRepository.cs 72.93% <ø> (ø)
...rce/backend/api/Services/AcquisitionFileService.cs 72.99% <28.57%> (-1.18%) ⬇️

... and 898 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 9, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit c61603a into bcgov:dev Nov 10, 2023
8 of 9 checks passed
@eddherrera eddherrera deleted the psp-7204 branch November 21, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants