psp-6988 File tabs fix #3575
Merged
psp-6988 File tabs fix #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3575 +/- ##
==========================================
+ Coverage 69.53% 74.53% +4.99%
==========================================
Files 1369 898 -471
Lines 33704 18575 -15129
Branches 6264 5244 -1020
==========================================
- Hits 23436 13844 -9592
+ Misses 10017 4731 -5286
+ Partials 251 0 -251
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asanchezr
reviewed
Nov 6, 2023
.github/workflows/ci-cd-pims-dev.yml
Outdated
| @@ -123,7 +123,7 @@ jobs: | |||
| - name: call scripts to upgrade database | |||
| shell: bash | |||
| run: | | |||
| oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_DEV -p NAMESPACE=3cd915-dev | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s) | |||
| oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p DB_SECRET_NAME=pims-database GIT_BRANCH=dev SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_DEV -p NAMESPACE=3cd915-dev | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s) | |||
There was a problem hiding this comment.
this doesn't seem related to that story but I guess we can fix it anyways?
There was a problem hiding this comment.
This was from #3573, removed from this PR.
asanchezr
reviewed
Nov 6, 2023
Comment on lines
68
to
73
| - name: GIT_BRANCH | ||
| description: the git branch to pull the database scripts from. | ||
| required: true | ||
| - name: DB_SECRET_NAME | ||
| description: the git branch to pull the database scripts from. | ||
| required: true |
There was a problem hiding this comment.
Question - I'm assuming the corresponding secrets have been updated/configured in OCP?
devinleighsmith
force-pushed
the
file_tabs_fix
branch
from
93718b6 to
89d0466
Compare
|
✅ No secrets were detected in the code. |
asanchezr
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.